mon / BemaniPatcher

Web based DLL binary patcher
MIT License
211 stars 134 forks source link

add sdvx eg support #252

Closed wz18207 closed 2 years ago

wz18207 commented 2 years ago

i have to admit that staying sane is a willpower drain.

Y2K-x commented 2 years ago

Just beat me to the punch, I had my PR all set up, and I check back and you had already submitted it! Darn! :P

In any case, I would suggest crediting where you had gotten the patches from, seems to me like you had pulled them from elpis.fun, comparing the two. Just good edicate.

mon commented 2 years ago

While we wait for a reply to Y2K's query, did you know there is also a "integer text entry" option for patches? It might make the FPS patch cleaner, but it might also just be too difficult...

wz18207 commented 2 years ago

Well, to be honest, the frame rate patch is quoted from my friend, I am not very clear about the specifics. I can revoke this commit if I allow it, I don't like the game itself. in fact I don't want to get into an argument with other people over this issue

drmext commented 2 years ago

elpis.fun just ran this https://github.com/drmext/BemaniPatcher/blob/c4d42b57b70c9e8eaf2f455cad9fb8fc265c29a2/docs/sdvx.py