mon / BemaniPatcher

Web based DLL binary patcher
MIT License
210 stars 135 forks source link

Various updates #311

Closed Tomo-Tg closed 1 year ago

Tomo-Tg commented 1 year ago

Addition of games that are no longer n-0 and games that are more than 1 year old, as well as updates to existing patches. I found some errors and re-pulled the pull request again. My apologies for the inconvenience.

mon commented 1 year ago

It's no problem, thanks for the contribution. I still need a day to find time to inspect properly, but some initial thoughts from a quick look

Tomo-Tg commented 1 year ago

I forgot that there is a rule that only Konami or rhythm games are allowed... For me, it is very convenient to be able to patch different games on one site. I would be happy if you could improve this rule

mon commented 1 year ago

The fake DRS patches call into question the whole PR - where did you get them? Which ones are actually tested?

Tomo-Tg commented 1 year ago

I collected and posted a collection of patches that I had saved on my pc. The DRS patch was a patch that was posted on some arcade forum a long time ago. I didn't think that the patch contained false and I have not tested it, I will test all the patches now, so please wait a while Sorry for the inconvenience. I will comment again when all tests are completed.

Tomo-Tg commented 1 year ago

So far, all of the patches we have tested have been fine. All of the games listed in the patches showed signs of having been uploaded once, but only DRS showed no signs of data having been uploaded at all, and with a little digging, it was easy to tell that it was a fake. I apologize for any inconvenience my mistake may have caused.

Patches that have been tested Tests have been completed.

Tomo-Tg commented 1 year ago

With the help of a friend, we were able to complete the test and no problems were identified. I have removed the DRS patch. My commit submitted the 2020-11-16 version of the nostalgia op3 patch, but now it looks like the 2021-12-22 version of the nostalgia op3 patch has also been submitted, so I think we need to integrate the patches, should I create them? If we do integrate, I will create an integrated patch and submit it to this commit.

mon commented 1 year ago

Thanks for your patience and thank you very much for the testing. I know it's a pain to do, and I really appreciate that you've spent the time.

I merged the other Op3 patches as they looked good, so yes, adjust yours to merge in the changes together.

I think I will adjust the submission rule to be "somewhat recent PC based arcade games" So kancolle, initial D, etc will be OK to submit. I will continue to tweak the rule if I get a lot of junk submissions for games outside of rhythm games.

Tomo-Tg commented 1 year ago

Am I able to commit without problems? Thank you for allowing initial D,kancolle , etc. I will make a pull request for the initial D patch in the next few days.

Tomo-Tg commented 1 year ago

I've added support for Initial D. Let me know if you have any problems.

mon commented 1 year ago

The review comments I left have yet to be resolved, please take a look at them.

Where'd the patch set come from? It seems quite comprehensive, especially the extra notes in the html.

mon commented 1 year ago

Also, there are merge conflicts that would need resolution

Tomo-Tg commented 1 year ago

I'm not familiar with Github and don't know where to find review comments, if you don't mind, could you please comment here? The idz patch was released on Emuline. It has been tested and I have committed it with my addition of tooltip.

mon commented 1 year ago

If you scroll up a little you can see "mon started a review" and the 2 comments I left on some of the files. They are marked with yellow "Pending" labels.

IDZ patch is OK then, thanks.

Tomo-Tg commented 1 year ago

I couldn't find the review no matter how many times I looked for it, so I did some research and found the information that reviews with the Pending label are not visible to others. Could you please make them visible to me?

mon commented 1 year ago

I couldn't find the review no matter how many times I looked for it, so I did some research and found the information that reviews with the Pending label are not visible to others. Could you please make them visible to me?

Oh my goodness, I am so sorry. I never even realised that was possible. Have made them un-pending.

Tomo-Tg commented 1 year ago

Fixed, is this a problem?