Closed aixxe closed 2 months ago
Huh, that's super weird, I would have expected the closure's variables to appropriately shadow the patch
variable. I'll take your word for it as being fixed - even if it's a red herring, byte
is a much better name for that argument!
Was originally going to make an issue for this but I ended up fixing it in the process. Original text detailing the bug below:
I think I've run into a bug with the output file when using dynamic patches. Here's one I wrote for the INFINITAS launcher:
I'm only replacing the first byte, so the rest is just there to make it sufficiently unique. I kept the wildcards in the
on
patch asXX
assuming it would only change the first byte and leave the rest untouched.After enabling the patch and saving the file, the output was a little different to what I expected.
It seems like the wildcard bytes are getting replaced with
00
instead of the original contents: