search

monaca / monaca-lib

npm package for handling Monaca cloud API and local debugging API
http://monaca.io
Other
14 stars 11 forks source link

Dev fix get local files #126

Closed yong-asial closed 6 years ago

yong-asial commented 6 years ago

filter local project files before calculating checksum

yong-asial commented 6 years ago

@masahirotanaka please have a look and merge if everything is ok.

yong-asial commented 6 years ago

refer to new PR - https://github.com/monaca/monaca-lib/pull/127

masahirotanaka commented 6 years ago

@erisu yes that's true, but that shouldn't be a problem if all Monaca templates has monacaignore by default. I prefer less complexity in our command line tool rather than having specific configs for each framework.

yong-asial commented 6 years ago

@erisu @masahirotanaka for now since we have build in .monacaignore, it will ignore every folder containing build directory.

masahirotanaka commented 6 years ago

Yes we need to optimize the default. Monacaignore but that can be done later. For monaca-Lib no need to do a complex thing in my opinion.