Discussion of the API - Githubissues

monadexio / monadex-api

0 stars 0 forks source link

Discussion of the API #2

Open h0ngcha0 opened 9 years ago

h0ngcha0 commented 9 years ago

Let's discuss the API using this issue page, I will drop few comments first =)

is created_at and ended_at duplicated with the length information?
what is the difference between sold and reservations? it can only be reserved, right?
frontend needs a backend service that checks if an URL is used or not.
frontend needs a backend service to retrieve the currently available tshirts and their variants
frontend needs a little artwork service from the backend, which returns the system artworks on demand.
do we need to add HTTP 410 Gone for expired campaign?
is it necessary or secure that the user json body has the password field?

hudayou commented 9 years ago

Since a campaign can be ended early by the designer, an additional field is required.

There are some status change when sold exceeds goal, before that you can only reserve and money is not charged, after that you can buy and money is charged instantly. Reservations should be removed anyway.

Let's make the basic things work at the begining and then add more features.

h0ngcha0 commented 9 years ago

Ok, I see.

After the campaign goal is reached user will be charged instantly if they wanna buy, is that the case on teespring.com? I never realised that. Thought they will still get an reservation.

h0ngcha0 commented 9 years ago

I am not entirely sure about using http basic authentication as the method of choice. Is it because Oauth2 is overly complicated? Are we not integrating with social login?

h0ngcha0 commented 9 years ago

Otherwise it is looking nice :+1: Lets have some discussion over the weekend!

hudayou commented 9 years ago

For code base, let's use the simplest authentication method. Oauth2 should be used anyway and should be added in later iterations.

h0ngcha0 commented 9 years ago

Got it!