Ready for Go Live - FB + Twitter Meta Tags

[loganbek]

I've added the initial version of the twitter + FB meta tags. I was able to use ngroc and my local copy to validate the twitter card but ran into issues with the facebook share debugger (from a quick search this seems like a common issue).

There's still some work to be done, but I thought this would be a good point to give you an update and ask a few clarifying questions.

1) You mention a page favicon. Are you looking for me to add one to the site? 2) Is there any harm in using yarn deploy to test against the live app?

Thanks!

[owocki]

Thanks, looking like were on the right track!

You mention a page favicon. Are you looking for me to add one to the site?

Yes pls

Is there any harm in using yarn deploy to test against the live app?

donno but @abbey-titcomb might

[owocki]

@loganbek from the screenshot it looks like the twitter card image doesnt show up tho.. we'll want the logo to show up there (it might hae to be a png not a svg)

[loganbek]

@owocki I'll look into getting a favicon added and ensure the images work on both FB and twitter cards. @abbey-titcomb Let me know if I can update the live app for testing. These changes shouldn't cause any issues since I'm just adding meta tags to the header.

[owocki]

thanks @loganbek mind also throwing up a WIP PR for responsiveness fixes too?

[owocki]

can we get this out of WIP? this is gonna go live tomo

[loganbek]

@owocki, this PR should be ready to go, although I'm still having trouble testing the FB card with the sharing debugger + ngrok. I've attached images of the favicon and the twitter card.

[abbey-titcomb]

Sorry @loganbek - just seeing this. Feel free to update live app for testing.

[owocki]

looks good to me!