monanadmin / monan

Repositório organizacional das atividades dos macro-grupos do MONAN - Model for Ocean-laNd-Atmosphere PredictioN
14 stars 10 forks source link

[GCC] PAD: Remover Arquivos de Compilação do MONAN-Model #478

Closed joaomas closed 2 months ago

joaomas commented 3 months ago

:people_holding_hands: User Story

COMO GCC, QUEREMOS remover arquivos de compilação do MONAN-Model, PARA corrigir uma falha técnica.

:clipboard: Critérios de aceite de conclusão da Issue

:pencil: Detalhamento adicional da atividade

N/A

:comet: Impactos

N/A

:link: Dependências

N/A

:hammer_and_wrench: Solução

Removidos os arquivos abaixo do modelo:

[denis.eiras@egeon-login1 MONAN-Model_develop_egeon.gnu940]$ git commit -m "#478 - removing unexpected files"
[develop 0ed1305] #478 - removing unexpected files
 37 files changed, 37573 deletions(-)
 delete mode 100644 default_inputs/namelist.atmosphere
 delete mode 100644 default_inputs/namelist.init_atmosphere
 delete mode 100644 default_inputs/stream_list.atmosphere.diagnostics
 delete mode 100644 default_inputs/stream_list.atmosphere.output
 delete mode 100644 default_inputs/stream_list.atmosphere.surface
 delete mode 100644 default_inputs/streams.atmosphere
 delete mode 100644 default_inputs/streams.init_atmosphere
 delete mode 100644 make-all.output
 delete mode 100755 make-all.sh
 delete mode 100755 make.sh
 delete mode 100644 namelist.atmosphere
 delete mode 100644 namelist.init_atmosphere
 delete mode 100644 src/core_atmosphere/inc/block_dimension_routines.inc
 delete mode 100644 src/core_atmosphere/inc/config_declare.inc
 delete mode 100644 src/core_atmosphere/inc/config_get.inc
 delete mode 100644 src/core_atmosphere/inc/core_variables.inc
 delete mode 100644 src/core_atmosphere/inc/define_packages.inc
 delete mode 100644 src/core_atmosphere/inc/domain_variables.inc
 delete mode 100644 src/core_atmosphere/inc/namelist_call.inc
 delete mode 100644 src/core_atmosphere/inc/namelist_defines.inc
 delete mode 100644 src/core_atmosphere/inc/setup_immutable_streams.inc
 delete mode 100644 src/core_atmosphere/inc/structs_and_variables.inc
 delete mode 100644 src/core_init_atmosphere/inc/block_dimension_routines.inc
 delete mode 100644 src/core_init_atmosphere/inc/config_declare.inc
 delete mode 100644 src/core_init_atmosphere/inc/config_get.inc
 delete mode 100644 src/core_init_atmosphere/inc/core_variables.inc
 delete mode 100644 src/core_init_atmosphere/inc/define_packages.inc
 delete mode 100644 src/core_init_atmosphere/inc/domain_variables.inc
 delete mode 100644 src/core_init_atmosphere/inc/namelist_call.inc
 delete mode 100644 src/core_init_atmosphere/inc/namelist_defines.inc
 delete mode 100644 src/core_init_atmosphere/inc/setup_immutable_streams.inc
 delete mode 100644 src/core_init_atmosphere/inc/structs_and_variables.inc
 delete mode 100644 stream_list.atmosphere.diagnostics
 delete mode 100644 stream_list.atmosphere.output
 delete mode 100644 stream_list.atmosphere.surface
 delete mode 100644 streams.atmosphere
 delete mode 100644 streams.init_atmosphere

Ao executar, surge o erro abaixo:

ERROR: In file streams.atmosphere, definition of stream "output" references file stream_list.atmosphere.output that cannot be opened for reading.
CRITICAL ERROR: stream xml get attribute failed: streams.atmosphere

O mesmo padrão ocorre para o stream "surface", quando este não existe

Em um primeiro teste, foi alterado o arquivo streams.atmosphere para remover as streams correspondentes, mas outros erros apareceram.

Logo, foi preciso manter os arquivos stream_list.atmosphere.output, stream_list.atmosphere.surface na execução. No entanto, esses arquivos não estão originalmente no código fonte do MPAS, logo, optou-se por os gerenciar dentro dos scripts, e estes foram incluídos:

[denis.eiras@egeon-login1 egeon_oper]$ git commit -m "#478 - including files removed in model" 
[develop 4ee0931] #478 - including files removed in model
 2 files changed, 112 insertions(+)
 create mode 100644 egeon_oper/namelist/stream_list.atmosphere.output
 create mode 100644 egeon_oper/namelist/stream_list.atmosphere.surface

:rotating_light: Problemas encontrados

N/A

:white_check_mark: Conclusão

Arquivos desnecessários removidos, mas foi preciso incluir alguns na pasta namelists dos scripts.

:spiral_calendar: Trabalhos Futuros

É preciso verificar se a inclusão dos arquivos stream_list.atmosphere.output, stream_list.atmosphere.surface nos scripts é a melhor solução.

Remover arquivos como estes no pacote do testcase/namelists, que provavelmente não estão sendo usados, pois o script 2 usa os da pasta namelists