search

monanadmin / monan

Repositório organizacional das atividades dos macro-grupos do MONAN - Model for Ocean-laNd-Atmosphere PredictioN
14 stars 10 forks source link

[GCC] PAD: Implementar nova versão do Convert_MPAS - CodeReview #484

Closed joaomas closed 2 months ago

joaomas commented 2 months ago

:people_holding_hands: User Story

COMO Saulo, QUEREMOS iniciar a implementação da nova versão do Convert MPAS, PARA aperfeiçoar o MONAN.

:clipboard: Critérios de aceite de conclusão da Issue

:pencil: Detalhamento adicional da atividade

:comet: Impactos

-.

:link: Dependências

473

:hammer_and_wrench: Solução

CodeReview

Understand

Image

Image

Image

Dependencies-DirectoryStructure:

Image

Calls&&CalledBy-src

Image

Resultados

CodeCheck:

Results Entity Line Column CheckID Check Name Ignored Note Severity Number of Results: 46
D:\INPE_GCC\repo\convert_mpas\src\convert_mpas.F90
Violation: convert_mpas defined but not called. convert_mpas 1 8 RECOMMENDED_13 Unused Functions
Unused Local Variable nMonths 38 14 RECOMMENDED_18 Unused Local Variables
Unused Local Variable path 442 29 RECOMMENDED_18 Unused Local Variables
D:\INPE_GCC\repo\convert_mpas\src\remapper.F90
Unreachable Code interior_element 0 0 RECOMMENDED_12 Unreachable Code
Unused Local Variable cellWeights 19 43 RECOMMENDED_18 Unused Local Variables
Unused Local Variable vertexWeights 20 43 RECOMMENDED_18 Unused Local Variables
Unused Local Variable edgeWeights 21 43 RECOMMENDED_18 Unused Local Variables
Unused Local Variable sourceCells 22 46 RECOMMENDED_18 Unused Local Variables
Unused Local Variable sourceVertices 23 46 RECOMMENDED_18 Unused Local Variables
Unused Local Variable sourceEdges 24 46 RECOMMENDED_18 Unused Local Variables
Unused Local Variable array4i 50 49 RECOMMENDED_18 Unused Local Variables
Unused Local Variable MPAS_CELL_FIELD 54 34 RECOMMENDED_18 Unused Local Variables
Unused Local Variable MPAS_VTX_FIELD 55 34 RECOMMENDED_18 Unused Local Variables
Unused Local Variable MPAS_EDGE_FIELD 56 34 RECOMMENDED_18 Unused Local Variables
Unused Local Variable CAM_CELL_FIELD 57 34 RECOMMENDED_18 Unused Local Variables
Unused Local Variable CAM_VTX_FIELD 58 34 RECOMMENDED_18 Unused Local Variables
Unused Local Variable CAM_EDGE_FIELD 59 34 RECOMMENDED_18 Unused Local Variables
Unused Local Variable UNSUPPORTED_FIELD 60 34 RECOMMENDED_18 Unused Local Variables
Unused Local Variable MPAS_MASK 63 34 RECOMMENDED_18 Unused Local Variables
Unused Local Variable CAM_MASK 64 34 RECOMMENDED_18 Unused Local Variables
Unused Local Variable CELL_MASK 67 34 RECOMMENDED_18 Unused Local Variables
Unused Local Variable VTX_MASK 68 34 RECOMMENDED_18 Unused Local Variables
Unused Local Variable EDGE_MASK 69 34 RECOMMENDED_18 Unused Local Variables
Unused Local Variable nearest_vertex 72 14 RECOMMENDED_18 Unused Local Variables
Unused Local Variable sphere_distance 73 14 RECOMMENDED_18 Unused Local Variables
Unused Local Variable mpas_arc_length 74 14 RECOMMENDED_18 Unused Local Variables
Unused Local Variable mpas_triangle_signed_area_sphere 75 14 RECOMMENDED_18 Unused Local Variables
Unused Local Variable mpas_wachspress_coordinates 76 14 RECOMMENDED_18 Unused Local Variables
Unused Local Variable convert_lx 77 14 RECOMMENDED_18 Unused Local Variables
Unused Local Variable j 91 17 RECOMMENDED_18 Unused Local Variables
Unused Local Variable nn 92 17 RECOMMENDED_18 Unused Local Variables
Unused Local Variable vertCoords 95 44 RECOMMENDED_18 Unused Local Variables
Unused Local Variable pointInterp 96 28 RECOMMENDED_18 Unused Local Variables
Unused Local Variable do 126 10 RECOMMENDED_18 Unused Local Variables
Violation: (Unnamed_Main) defined but not called. (Unnamed_Main) 128 6 RECOMMENDED_13 Unused Functions
Unused Local Variable j 853 17 RECOMMENDED_18 Unused Local Variables
Unused Local Variable iy 854 17 RECOMMENDED_18 Unused Local Variables
Unused Local Variable ix 854 21 RECOMMENDED_18 Unused Local Variables
Unused Local Variable j 951 17 RECOMMENDED_18 Unused Local Variables
Unused Local Variable iy 952 17 RECOMMENDED_18 Unused Local Variables
Unused Local Variable ix 952 21 RECOMMENDED_18 Unused Local Variables
Unused Local Variable j 990 17 RECOMMENDED_18 Unused Local Variables
Unused Local Variable iy 991 17 RECOMMENDED_18 Unused Local Variables
Unused Local Variable ix 991 21 RECOMMENDED_18 Unused Local Variables
Violation: remap_get_target_z_iso_levels defined but not called. remap_get_target_z_iso_levels 1194 20 RECOMMENDED_13 Unused Functions
Unused Local Variable rad2deg 1229 25 RECOMMENDED_18 Unused Local Variables

Erros:

Image

Correções:

Linha 117 , src_mesh%nCells, src_mesh%maxEdges, src_mesh%nEdgesOnCell, src_mesh% & , src_mesh%nCells, src_mesh%maxEdges, src_mesh%nEdgesOnCell, src_mesh%cellsOnCell &

Linha 172 , src_mesh%nCells, src_mesh%nVertices, src_mesh%maxEdges, 3, src_mesh% & , src_mesh%nCells, src_mesh%nVertices, src_mesh%maxEdges, 3, src_mesh%nEdgesOnCell &

Linha 247 %sourceEdges(1:nn, ix, iy) = src_mesh%edgesOnCell(1:nn, idx) remap_info%sourceEdges(1:nn, ix, iy) = src_mesh%edgesOnCell(1:nn, idx)

Image

Branch atualizada.

DTN-01

Exemplo de analise usando a DTN-01 para casos futuros:

4.11.2 Mandatória: Sempre coloque um comentário na linha seguinte, precedido por duas exclamações (“!!"), explicando a constante e sua unidade.

Resultado: foi encontrado poucos comentários no código.

4.66 Mandatória: Os cabeçalhos de módulos devem seguir o padrão FORD e devem ter o seguinte formato: (...)

Resultado: código não atende

(...)

:rotating_light: Problemas encontrados

-.

:white_check_mark: Conclusão

:spiral_calendar: Trabalhos Futuros

-.

joaomas commented 2 months ago

Fluxo do CodeReview:

joaomas commented 2 months ago

@deniseiras @luflarois @klclaudio finalizado o "codereview" usando o Understand... não foi revisto todas as regras mandatórias da DTN-01. Citei em solução um exemplo de como seria esta análise que manualmente demandaria muito tempo.