search

monaqa / satysfi-figbox

A SATySFi package that creates charts and places them in inappropriate positions.
MIT License
8 stars 3 forks source link

png support #5

Open SnO2WMaN opened 2 years ago

SnO2WMaN commented 2 years ago

As you probably already know, SATySFi has been supported png image https://github.com/gfngfn/SATySFi/pull/329.

Currently, in my environment with the latest SATySFi and this package, loading png images with like +fig-on-left command does not crash when building document, but does not output images.

Could you check this problem?

monaqa commented 2 years ago

Thanks for the report. satysfi-figbox does not support loading PNG images yet, because SATySFi itself has not yet officially released the feature. However, it is easy to implement, so I tried supporting the PNG loading feature in feat-include_png branch. Please try it out on your own, as it has not been tested yet.

SnO2WMaN commented 2 years ago

I tested feat-include_png and looked to be worked successfully. Thanks for your quick response!

nsfisis commented 8 months ago

Hi, I noticed that https://github.com/gfngfn/SATySFi/pull/329 has been merged to the master branch and has already been released as SATySFi v0.8.0. I attempted to use feat-include_png branch of the repository with SATySFi v0.8.0, but the version constraint of the package requires that version of SATySFi is older than v0.8.0. Do you have any plan to merge the branch into master and update the version requirement?