monarc-project / MonarcAppFO

MONARC - Method for an Optimised aNAlysis of Risks by @NC3-LU
https://www.monarc.lu
GNU Affero General Public License v3.0
101 stars 39 forks source link

Incorrect sum and list of risks #382

Closed ruslanbaidan closed 3 years ago

ruslanbaidan commented 3 years ago

Discussed in https://github.com/monarc-project/MonarcAppFO/discussions/381

Originally posted by **KonzeptAcht** September 1, 2021 **Describe the bug** For some assets that have received dependent assets through linking, their risk listing does not show the risks of the linked assets **To Reproduce** Steps to reproduce the behavior: 1. import the myprint EN 2. select "Computer graphics department" 3. check information risks of "Front Office" (30 risks are listed, which represents a correct summation of the risks of the dependent assets) 4. Review of the "Specific software" asset, which is subordinate to the "Front Office" (only 6 information risks are shown here, although with the linked asset "Specific software maintenance" 11 would be the correct value) **Expected behavior** correct summation of all risks from the selected asset, as well as all related assets **Screenshots** ![grafik](https://user-images.githubusercontent.com/47662401/131748880-03996cad-73fe-4f05-b6f8-87c78893c947.png) ![grafik](https://user-images.githubusercontent.com/47662401/131748921-d2345120-ada2-408f-a747-57f79f05bdfd.png) ![grafik](https://user-images.githubusercontent.com/47662401/131748959-b747e159-9f83-44a1-b52c-2d9486bd826f.png) **Desktop (please complete the following information):** | Questions | Answers |-----------------------------------------|-------------------- | Type of issue | Bug | OS version (server) | Ubuntu 18.04 LTS | OS version (client) | MacOS, Win10, Ubuntu, Debian | PHP version | 7.4 | MONARC version / git hash | 2.10.4 | Browser | Firefox, Chrome, Safari **Additional context** The case is not only with sum of risks (displaying a correct number), but listing of them. The situation happens only with secondary assets, when there is a composition of secondary asset inside of another secondary asset. By the logic we don't display children assets' risks when parent secondary is selected, but Edit Impact functionality will modify the children assets' risks values.
ruslanbaidan commented 3 years ago

Dear MONARC community, Could you share your please opinion on this topic:

Poll: