search

monarc-project / MonarcAppFO

MONARC - Method for an Optimised aNAlysis of Risks by @NC3-LU
https://www.monarc.lu
GNU Affero General Public License v3.0
101 stars 38 forks source link

[FrontOffice] Recommendations can be linked to the same risk more than once #457

Closed ruslanbaidan closed 1 year ago

ruslanbaidan commented 2 years ago

Describe the bug The same recommendations are linked to the same risks more than once.

To Reproduce To be described.

Expected behavior Recommendations should not be duplicated.

Screenshots Screenshot 2022-09-12 at 15 19 12

ruslanbaidan commented 2 years ago

The frontend duplication was fixed by validating if riskId is set to fetch the recommendations-risks data.

The following things to do:

  1. There is a loading time issue in case of many recommendations linked to risks. As a solution, the linked recommendations can be added to the risk data when we open it for edit.
  2. The recommendations duplications for the global risks that are presented more than once in the analysis. The second one has duplicated the same recommendation.