monarc-project / MonarcAppFO

MONARC - Method for an Optimised aNAlysis of Risks by @NC3-LU
https://www.monarc.lu
GNU Affero General Public License v3.0
101 stars 39 forks source link

The trashbin button to delete a risk on a specific asset does not work #520

Closed acherifi closed 11 months ago

acherifi commented 11 months ago

Describe the bug When a Information Risk is removed from the knowledge base, informations risk on the affected assets appear in blue with a trash bin icon to remove the risk. This button does not work. No error appear when clicking the trashbin but the risk is still present.

To Reproduce Steps to reproduce the behavior:

  1. Add an asset to an asset type
  2. Evaluate the risk for this asset
  3. Remove the information risk linked to the asset type
  4. Try to remove the risk on the asset

Expected behavior The risk should be deleted

Screenshots Before clicking the icon image

After clicking image

Desktop (please complete the following information):

Questions Answers
Type of issue Bug
OS version (server) Ubuntu
OS version (client) Ubuntu
PHP version The embedded in the Monarc VM
MONARC version / git hash Latest production
Browser Chrome
ruslanbaidan commented 11 months ago

I can confirm the issue. It is related to the global secondary assets' link and removal of other risks. We are going to provide a fix for that soon, but it would be necessary to migrate to a new VM. Could you tell if the Monarc cloud service solution works for you ? So we can create an instance for your organisation and the updates will be done automatically without needs to migrate.

acherifi commented 11 months ago

If the cloud solution provides the same feature set we would be glad to have an instance.

ruslanbaidan commented 11 months ago

If the cloud solution provides the same feature set we would be glad to have an instance.

It's the same tool. The instances are deployed per organisation https://www.monarc.lu/service/ Could you request the access by contacting us on the email instance-monarc@nc3.lu with your organisation name and primary user first, last names and email address.

acherifi commented 11 months ago

Thank you very much. The email has been sent.

acherifi commented 11 months ago

Another question: I am trying to import a JSON risk assessment file. If the import takes longer than the session timeout, is the import fully done or does the session timeout interrupt the import ?

ruslanbaidan commented 11 months ago

Another question: I am trying to import a JSON risk assessment file. If the import takes longer than the session timeout, is the import fully done or does the session timeout interrupt the import ?

Import process will be continued after the session timeout reached until it's done or failed.

ruslanbaidan commented 11 months ago

https://github.com/monarc-project/zm-client/pull/70

acherifi commented 11 months ago

Thank you very much for the fix. I solved my issue with a quickfix by removing in the DB, the instances_risks with an amv_id at null

DELETE FROM monarc_cli.instances_risks
WHERE amv_id is NULL;
ruslanbaidan commented 11 months ago

Thank you for the information. It could be that the missing amvs appeared when there was an issue with removal. It would be good to try reproducing this issue on the latest code base (with applied code fix). New VM is also available. And if those records appear by the other reasons, we have to look for an another issue.

acherifi commented 11 months ago

I can confirm that it works perfectly on the latest code base with the fix. Thank you for the reactivity

ruslanbaidan commented 11 months ago

You are welcome. Thanks for the confirmation.