search

monarch-initiative / PhenoteFX

PhenoteFX
https://monarch-initiative.github.io/PhenoteFX/
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Tableview fix #37

Closed kingmanzhang closed 5 years ago

kingmanzhang commented 5 years ago

I think I fixed the bug (https://github.com/monarch-initiative/PhenoteFX/issues/34). The problem is that calling getRow() from a table cell may give you an incorrect row item. The change made here is to call getIndex() to get the index of underlying data and then retrieve data from the index. I am not confident that I understand why it does that, but I think it has something to do with how JavaFX binds data to physical rows (when you scroll, a row may have a new data rendered there(I think it is the reason why getRow returns a wrong item)). @LCCarmody let me know if you still see bugs (or new bugs due to the fix).

LCCarmody commented 5 years ago

I’ll try. Let me know when there is a new release