search

monarch-initiative / SEPIO-ontology

Ontology for representing scientific evidence and provenance information
49 stars 10 forks source link

Label and definition modifications for SEPIO:0000187 Confidence level #42

Open pfabry opened 1 year ago

pfabry commented 1 year ago

Confidence level is currently defined as: "A data item that quantifies the level of confidence an agent has that a particular piece of information is true." A confidence level quantifying a level of confidence seems circular to us.

Moreover, since confidence level is asserted as a subclass of measurement datum, its definition should read: "A measurement datum that [...]"

Suggested label: confidence level measurement datum This can avoid a confusion with a possible mental entity that would be the confidence level of some agent.

matentzn commented 1 year ago

@pfabry thank you for the issue!

Would you feel confident to make a PR to that end? I will try to wave it through.

pfabry commented 1 year ago

@matentzn Thank you for your swift answer! Will do a PR :-)

Also, a confidence level is axiomatized as being about a statement and it seems it could be used in the definition. The proposed definition would read as follows: "A measurement datum that quantifies the level of confidence an agent has that a particular statement is true."

mbrush commented 1 year ago

Thanks for the feedback @pfabry. I agree with your proposal but would change the axiom on this class to real 'is about some information content entity', and adjust your proposed definition accordingly. Confidence levels can be about other types of information besides statements. I amended your PR accordingly. Let me know if this sounds reasonable, and I can approve the change.

Also, please note the text I added to the SEPIO readme file, concerning the development status of the SEPIO Ontology. This includes a warning for users that this still a pre-release version that will undergo some refactoring ahead of an official first release later this year - mainly to align with work in the GA4GH Variant Annotation effort which is where the information model underlying SEPIO is currently evolving to support use cases coming from this project.

pfabry commented 1 year ago

That sounds perfectly reasonable to us. Thank you.