search

monarch-initiative / SLDBGen

6 stars 3 forks source link

Name change #135

Closed pnrobinson closed 4 years ago

pnrobinson commented 4 years ago

I would like to rename the repo

vidarmehr commented 4 years ago

@pnrobinson Are we going to use this repo to generate SL data only?

pnrobinson commented 4 years ago

yes!

vidarmehr commented 4 years ago

So, I vote for SLDBGen.

Other ideas: SLDataGen

LeoPompidou commented 4 years ago

SLDBGen is fine

LucaCappelletti94 commented 4 years ago

Personally, I would suggest to keep it as something very explicit like synthetic_letality or synthetic_letality_data, so that if one uses it in python like:

from synthetic_letality import load_data

one would immediately guess what that line is doing, as compared to, for instance:

from SLDBGen import load_data

Since the proposed names are not whimsical or compose any easy to remember the word, I don't think they would help the use of the repository.

What do you think?

pnrobinson commented 4 years ago

@LucaCappelletti94 I do not think very many people will use this outside of ourselves -- most users will simply want the data file (a TSV). The package makes it easier for us and let's us document the data generation for a publication.

pnrobinson commented 4 years ago

done!