search

monarch-initiative / biolink-api

API for linked biological knowledge
https://api.monarchinitiative.org/api/
BSD 3-Clause "New" or "Revised" License
64 stars 25 forks source link

ribbon / slimmer function: "evidence_with" should include - label, id, and taxon - for each entry #209

Open nathandunn opened 6 years ago

nathandunn commented 6 years ago

not sure how doable this is within biolink: https://github.com/geneontology/ribbon/issues/50

deepakunni3 commented 6 years ago

@nathandunn Allele IDs to allele symbols? Is there an example? I don't think I have access to view the JIRA ticket.

nathandunn commented 6 years ago

@deepakunni3 The ticket is here: https://agr-jira.atlassian.net/browse/AGR-1097

You should be able to register, but I'll paste it to save time:

I think it would be helpful to translate the allele IDs in the GO tables to the allele symbols. This would help users connect the alleles used to make GO annotations to the alleles shown elsewhere on the Alliance page. See for example https://test.alliancegenome.org/gene/MGI:97487 MGI IDs in the based on column are for alleles that are shown in the phenotypes, disease associations and allele tables lower on the page.

selewis commented 6 years ago

Are these really allele IDs? If they are in the GO tables, they are definitely -NOT- allele IDs, they are gene IDs (because that is what GO annotates to).

Basically it's about what is being returned in the response. Right now in the JSON field being returned labeled "evidence_with" there is just a simple list of ids. It would be be preferred if each entry in this "evidence_with" list looked similar to the "subject" entry and included - label, id, and taxon - for each entry.

nathandunn commented 6 years ago

@selewis I think the original case reported MGI alleles. But I think that your point is still valid and would be good to expand this if possible.