search

monarch-initiative / biolink-api

API for linked biological knowledge
https://api.monarchinitiative.org/api/
BSD 3-Clause "New" or "Revised" License
64 stars 25 forks source link

Proposal for rows #234

Closed lpalbou closed 4 years ago

lpalbou commented 5 years ago

We can change it here or in ontobio, but we only have 3 functions here and I don't see why this default value could not be infinite ? Furthermore, if we change it in ontobio, it would prevent any API call to actually change this value if needed

deepakunni3 commented 5 years ago

@lpalbou IMO, the default not being infinite is to prevent unnecessary calls hammering an existing Solr instance. Of late, we (Monarch and GO) have been noticing high amount of traffic hitting our instances with more than a handful being scripted requests with the goal of performing bulk retrieving operations.

If every call defaults to give all rows then the amount of documents sent back for each call will be large. I do see this as a side effect to this change. So perhaps changing at the Ontobio would end up causing more trouble than its worth.

If we are changing just for one or two routes then that seems more justified.

But I will defer to @cmungall, @kltm and @kshefchek to chime in on this change.

cmungall commented 5 years ago

going through all old PRs, what is the status of this?