fix association counts, clinical modifiers, and inheritance - Githubissues

monarch-initiative / biolink-api

API for linked biological knowledge

https://api.monarchinitiative.org/api/

BSD 3-Clause "New" or "Revised" License

64 stars 25 forks source link

fix association counts, clinical modifiers, and inheritance #250

Closed kshefchek closed 5 years ago

kshefchek commented 5 years ago

Fixes bug in stats_field
@api.marshal_with(bio_object) decorator broke dynamic marshalling (for inheritance, clin mod)
Use clique leader for collecting stats (for gene ortholog stats)

When pushed to production the following should work: http://api.monarchinitiative.org/api/bioentity/disease/OMIM%3A168600?rows=100&unselect_evidence=false&exclude_automatic_assertions=false&fetch_objects=true&use_compact_associations=false&get_association_counts=true

http://api.monarchinitiative.org/api/bioentity/gene/NCBIGene%3A84570?rows=100&unselect_evidence=false&exclude_automatic_assertions=false&fetch_objects=true&use_compact_associations=false&get_association_counts=true

DoctorBud commented 5 years ago

+1

Looks like an improvement to me, but I haven't tested it. I'd like to merge it and try it out in monarch-ui.

I'm not sure how to 'Review' this PR. Maybe this comment will suffice?

deepakunni3 commented 5 years ago

@kshefchek Thanks for fixing these 👍