Add missing routes - Githubissues

monarch-initiative / biolink-api

API for linked biological knowledge

https://api.monarchinitiative.org/api/

BSD 3-Clause "New" or "Revised" License

63 stars 25 forks source link

Add missing routes #283

Closed deepakunni3 closed 5 years ago

deepakunni3 commented 5 years ago

Add the following missing routes:

bioentity/variant/<id>/models
bioentity/model/<id>/cases
bioentity/genotype/<id>/cases
bioentity/phenotype/<id>/cases
bioentity/gene/<id>/cases
bioentity/disease/<id>/cases
bioentity/variant/<id>/cases
bioentity/case/<id>/models
bioentity/case/<id>/diseases
bioentity/case/<id>/variants
bioentity/case/<id>/genotypes
bioentity/case/<id>/genes
bioentity/case/<id>/phenotypes

Fixes #278

kshefchek commented 5 years ago

We can replace the filters with association_type = "x_y" (for example fq=association_type:case_phenotype) - slightly simpler.

deepakunni3 commented 5 years ago

@kshefchek Not sure which filters you are referring to. Is it wrong to fetch the associations using subject_category and object_category? Or are we expecting the same results either way?

I used this approach for consistency with other routes. Let me know if association_type is going to be a more permanent way of recognizing an association in Solr. I can make a note for future improvements :)

kshefchek commented 5 years ago

Theres nothing wrong with it, I just think it's an improvement going forward (and going back and replacing them), see https://github.com/biolink/biolink-api/issues/276