monarch-initiative / biolink-api

API for linked biological knowledge
https://api.monarchinitiative.org/api/
BSD 3-Clause "New" or "Revised" License
64 stars 25 forks source link

Slimmer function route: duplicated results ? #312

Open lpalbou opened 5 years ago

lpalbou commented 5 years ago

Test query: https://api.monarchinitiative.org/api/bioentityset/slimmer/function?slim=GO:0016043&subject=MGI:88276&rows=-1

Look for "regulation of histone demethylase activity (H3-K4 specific)". There are two associations for that GO term but except for the association id, those are duplicate.

Looking at the GOLR level query, we still have the two annotations to that term but they differ in the annotation_extension_class and annotation_extension_json fields which are not in the biolink association response, hence appearing as duplicates:

Screen Shot 2019-08-19 at 6 07 50 AM

Since the Alliance has also been asking for the annotation extension data to be provided for some time, the favored fix would probably be to include those annotation extension fields in the biolink association response.

@cmungall do we include those fields and what would you prefer ? (e.g. new field "extension" in object ?).