monarch-initiative / biolink-api

API for linked biological knowledge
https://api.monarchinitiative.org/api/
BSD 3-Clause "New" or "Revised" License
64 stars 25 forks source link

Add association type endpoint #330

Closed kshefchek closed 4 years ago

kshefchek commented 4 years ago

Adds generic association type endpoint (for monarch solr), for example /api/association/type/gene_function?fetch_objects=true&start=0&rows=25&unselect_evidence=true&subject=HGNC:3603

closes https://github.com/biolink/biolink-api/issues/276

kshefchek commented 4 years ago

I noticed we use "category" in the serializers code and "categories" in the biomodel/core code, resulting in category being null in some cases in API responses, I've switched categories to category in core.py to fix this but curious if theres a preference for one over the other

deepakunni3 commented 4 years ago

@kshefchek Yes, the preference is category instead of categories. I did try to fix it earlier, but looks like I might have missed a few places in the code.

cmungall commented 4 years ago

Correct. http://w3id.org/biolink/vocab/category

On Fri, Oct 18, 2019 at 2:52 PM Deepak notifications@github.com wrote:

@kshefchek https://github.com/kshefchek Yes, the preference is category instead of categories. I did try to fix it earlier, but looks like I might have missed a few places in the code.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/biolink/biolink-api/pull/330?email_source=notifications&email_token=AAAMMOLEGP463JCBHUQBGF3QPIV3NA5CNFSM4JCL57D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBWE2WQ#issuecomment-543968602, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMMOI7RXGHQF6ADQE5YLTQPIV3NANCNFSM4JCL57DQ .