monarch-initiative / biolink-api

API for linked biological knowledge
https://api.monarchinitiative.org/api/
BSD 3-Clause "New" or "Revised" License
63 stars 25 forks source link

Switch from 'categories' field to 'category' in model and serializers #335

Closed deepakunni3 closed 4 years ago

deepakunni3 commented 4 years ago

@kshefchek

kshefchek commented 4 years ago

I thought I got all these over in https://github.com/biolink/biolink-api/pull/330#issuecomment-543967657 but I'll have to take a closer look

kshefchek commented 4 years ago

here is that commit - https://github.com/biolink/biolink-api/pull/330/commits/b2105e9161097bb40791e2c9439d8e0497c1e120

deepakunni3 commented 4 years ago

Any chance we can get #330 merged in soon?

If not, I would vote for this PR to be merged as I can get the latest change running off of api-dev

This is a dependency for a demo for STAGE that isn't working anymore because category ends up as null

kshefchek commented 4 years ago

is stage running off of api prod or dev? api-dev is running off of #330 so perhaps I missed one

deepakunni3 commented 4 years ago

Oh! I was not aware of that.

The demo was using prod until now. I switched to dev. I'll close this PR since what I want is already in dev.

Confirmed by the following query: https://api-dev.monarchinitiative.org/api/bioentity/HP:0002099