search

monarch-initiative / biolink-api

API for linked biological knowledge
https://api.monarchinitiative.org/api/
BSD 3-Clause "New" or "Revised" License
63 stars 25 forks source link

Fix gene/<id>/homologs to use homology type #8

Open cmungall opened 7 years ago

cmungall commented 7 years ago

The API allows the provision of any relationship type for any route that returns association objects (the precomputed relation closure in solr is used for this).

However, for specific routes like /gene//homologs, we want to provide a convenience enum, e.g. corresponding to O/P/LDO. These would trivially map to the RO ID.

We will follow this design pattern in other places where a fixed set of relations are used to connect two categories - e.g. drug-disease, disease-model

cmungall commented 7 years ago

See @kshefchek's commit here: https://github.com/monarch-initiative/monarch-app/pull/1444/commits/4a95f1ff899b98afa6a5b1c2166ff64f9ffe2e46

deepakunni3 commented 6 years ago

@kshefchek Can we close this? It looks like this call does have the required homology type enums.