search

monarch-initiative / deprecated-human-disease-ontology

Deprecated, see README
Other
0 stars 0 forks source link

SHOUTY ALL CAPS sneaking back in #18

Closed cmungall closed 9 years ago

cmungall commented 9 years ago

probably coming from omimclusters, which has its own pipeline for pulling in omim. We should swap in our version

mellybelly commented 9 years ago

would also be great to have better descriptions that @nlwashington created. @sbello check impact on MGI

sbello commented 9 years ago

MGI has a separate translation process that occurs during the OMIM load. Changing names of OMIM terms in the omimclusters file would have no impact on MGI.

nlwashington commented 9 years ago

you can see the label scrubbing i do in dipper for OMIM here: https://github.com/monarch-initiative/dipper/blob/master/dipper/sources/OMIM.py

in the function _cleanup_label it involves:

  1. remove the abbreviation suffixes
  2. convert the roman numerals to integer numbers
  3. make the text title case, except for conjunctions/prepositions/articles
nicolevasilevsky commented 9 years ago

This issue was moved to monarch-initiative/monarch-disease-ontology#26