Open TomConlin opened 7 years ago
Can we determine where we're not applying this annotation? This indicates we're not consistently processing blank nodes - unless I'm misremembering how it works.
> Can we determine where we're not applying this annotation?
every file not listed above which contains a blank node (i.e. everything else)
I do not want to continue using the MONARCH:MONARCH_anonymous
predicate in any case. Monarch's predicates should ALL be resolvable ontological terms found in an OWL files.
I would hope if neo4j required blank nodes to be annotated as anonymous
we would do that uniformly on scigraph ingest based on recognizing blank nodes based on curie prefix _:
or skolem IRI
IMHO, we need to remove all uses of the anonymous designation upstream before clearing it out:
https://github.com/monarch-initiative/monarch-cypher-queries/search?utf8=%E2%9C%93&q=anonymous
Other options:
Going back to my PR on this - it looks like I intentionally only annotated variant blank nodes: https://github.com/monarch-initiative/dipper/pull/424
In a tiny minority of files we redundantly annotate blank nodes as
anonymous
using the only non-ontologically derived predicate in all of Monarch.With the overwhelming majority of blank nodes unannotated and working it is likely we realized we should derive the annotation from the structure the bnode where necessary and thus safe to remove these vestigial annotations.