search

monarch-initiative / dipper

Data Ingestion Pipeline for Monarch
https://dipper.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
57 stars 26 forks source link

FlyBase: skip derived_pheno_manifest in parsing allele phenotype association file #911

Closed kshefchek closed 4 years ago

kshefchek commented 4 years ago

Fixes https://github.com/monarch-initiative/dipper/issues/910

See also https://github.com/monarch-initiative/dipper/issues/770

kshefchek commented 4 years ago

Oddly, travis is not showing a failure when our tests are failing: https://travis-ci.org/monarch-initiative/dipper/builds/653194301, this PR definitely breaks the flybase tests

TomConlin commented 4 years ago

it is because my python virtual env check eats the error

https://github.com/monarch-initiative/dipper/blob/master/Makefile#L13

we can likely find a way to both have an informative message and propagate the error