search

monarch-initiative / dipper

Data Ingestion Pipeline for Monarch
https://dipper.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
56 stars 26 forks source link

Makefile error propagation and misc lint & minor refactor #912

Closed TomConlin closed 4 years ago

TomConlin commented 4 years ago

My checking if within a python virtual env ate the errors travis needed to break a build on unit test failure. errors were displayed but did not stop the world.

move more owl file fetching from ad-hoc locations to obo.

change from maintaining a set to appending to a list, then making a set once when done.

rest is comments and whitespace

moved a script never used here to transdipperator

reactome & worm fail travis tests (but not local tests or production runs) because they relied on files they did not fetch existing.

TomConlin commented 4 years ago

Yea! it fails hard again!

Makefile:51: recipe for target 'test_impc' failed

make: *** [test_impc] Error 1

The command "make" exited with 2.

Done. Your build exited with 1.
kshefchek commented 4 years ago

The test passes, try:

python -m unittest tests/test_impc.py

but fails with

make test
TomConlin commented 4 years ago

Had omitted a pair of parens please try again