monarch-initiative / dipper

Data Ingestion Pipeline for Monarch
https://dipper.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
56 stars 26 forks source link

UDP & misc #917

Closed TomConlin closed 4 years ago

TomConlin commented 4 years ago

UDP (which I cannot run) got explicit MONARCH: curie prefix. Relying on default base prefix results in a colon where we expect an underscore when processed with standard tools. (remember to fix tests)

Trying a run without duplicating metadata in the main graph, should eliminate whole classes of edge cases in post processing.

Far fewer hardcoded curiemap exceptions (for graphviz dot) theses days.

recently added try/except referenced non existent .read() function

spelling in comments type corrections

TomConlin commented 4 years ago

that is odd, I do not get a make fail on dataset unit test locally.