update common taxa in jenkins

monarch-initiative / dipper

Data Ingestion Pipeline for Monarch

https://dipper.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

56 stars 26 forks source link

update common taxa in jenkins #995

Closed kshefchek closed 3 years ago

kshefchek commented 3 years ago

although I think this will break parsers where the taxon is not yet configured, should we be defensive and fail hard or output a warning?

TomConlin commented 3 years ago

Sure, it is a great day to blow up all the things. Plus prod is freshly updated so we have a bit of grace to fix or back out. I think I left any species out of the common set that could not work when the common set was used, and this is most likely a departure from that, but one that if accommodated would make including future species easier

TomConlin commented 3 years ago

string unit test needing more is not surprising

kshefchek commented 3 years ago

i'm going to close as i'm pretty sure this is going to break something when a taxon is not supported by a source