monarch-initiative / genophenocorr

Genotype Phenotype Correlation
https://monarch-initiative.github.io/genophenocorr/stable
MIT License
4 stars 1 forks source link

Variant #12

Closed pnrobinson closed 1 year ago

pnrobinson commented 1 year ago

@lnrekerle

This is dangerous because perhaps the user gives us some other input.

 if reference == 'hg37':
                    ens = pyensembl.ensembl_grch37
                else:
                    ens = pyensembl.ensembl_grch38
                myVar = vc.Variant(contig, start, ref, alt, ensembl = ens)

it should probably be

 if reference == 'hg37':
                    ens = pyensembl.ensembl_grch37
                elif reference == 'hg38':
                    ens = pyensembl.ensembl_grch38
              else:
                    raise ValueException("some message")
    myVar = vc.Variant(contig, start, ref, alt, ensembl = ens)
lnrekerle commented 1 year ago

Done in Develop