monarch-initiative / genophenocorr

Genotype Phenotype Correlation
https://monarch-initiative.github.io/genophenocorr/stable
MIT License
4 stars 1 forks source link

Draw variants, transcript and protein. #124

Open ielis opened 6 months ago

ielis commented 6 months ago

Todos:

frehburg commented 6 months ago

Hey @ielis,

I got started and played around with the visualization a bit and copied the image Lauren showed last time. As of now it looks like this:

image

This is Laurens image:

64DEBF77-7835-422A-A769-6B8310E59BF3

My function looks as such: draw_fig(limits, protein_limits, markers) Where limits is and array of tuples where tuple[0] is the beginning of a box on the upper line and tuple[1] is the end. protein_limits is just a 1D array of strictly increasing numbers and the boxes on the lower line are drawn with consecutive pairs taken from this list. I figured this would be sufficient, since there don't seem to be any gaps as above. Lastly, markers is also just a 1D array of x positions and I draw a little pin at that location, increasing the stem length and circle radius the more often the same x appears.

I would imagine that this method is a good starting point to develop the figure you have in mind. Visually everything can be customized to adhere more to your preferences. The bioinformatics logic can be added to give my drawing method the right inputs. Etc etc.

Please let me know what you think

pnrobinson commented 6 months ago

awesome!

ielis commented 6 months ago

Hi @frehburg the picture looks indeed awesome! I'll write some prose into the notebook in this repo to make sure we are on the same page but overall I think this is fabulous!

I'll let you know when I'm done with the prose.

Thanks a lot! :)

lnrekerle commented 1 week ago

I think all that's left of this task is having a legend for the variant effect colors! @frehburg is this something you can work on? And thank you so much for all the work you've done on the visualization!!