search

monarch-initiative / genophenocorr

Genotype Phenotype Correlation
https://monarch-initiative.github.io/genophenocorr/stable
MIT License
4 stars 1 forks source link

ProteinMetadata #164

Open pnrobinson opened 1 month ago

pnrobinson commented 1 month ago

I added extraction of protein length from the UniProt API, and it seems to work. However, about ten tests create ProteinMetadata objects currently without length. I therefore set a default value of zero to be able to move forward. We need to refactor the tests and to remove the default value.

ielis commented 1 month ago

Note that you can use TranscriptCoordinates.get_codon_count() to get the protein length. It should almost always correspond to the protein length, right?

pnrobinson commented 1 month ago

In principle, yes. We could also check that the two are equal, that would be a good check!