monarch-initiative / genophenocorr

Genotype Phenotype Correlation
https://monarch-initiative.github.io/genophenocorr/stable
MIT License
4 stars 1 forks source link

add key with colors and names of protein ffeatures #171

Open pnrobinson opened 1 month ago

pnrobinson commented 1 month ago

For each unique feature name, use the same color. If the name is more than 5 characters, use an abbreviation (e.g., "A", "B", etc...) in the main protein figure. Add a legend with one row per feature that shows a color box, the abbreviation if any, and the full name

Do the same for the variant class lollipops

frehburg commented 1 month ago

image

New params:

pnrobinson commented 1 month ago

Looks great! Wow! PS -- vielleicht so was Ähnliches für die Lollipops?

pnrobinson commented 1 month ago

@frehburg Please add adjust the title of the graphic. Protein name should come from protein_meta.label (and not be the accession number). Also please remove "Working title"!

ielis commented 1 month ago

I fixed the title and added the protein name, the updated code is already in develop.

The rest of this issue is, however, most likely still current.