monarch-initiative / genophenocorr

Genotype Phenotype Correlation
https://monarch-initiative.github.io/genophenocorr/stable
MIT License
4 stars 1 forks source link

now creates a cohort #19

Closed lnrekerle closed 1 year ago

lnrekerle commented 1 year ago

Added more variant tests. Changed it back to finding all transcripts. Figured out what needed to be tuples so the items could be hashed.

lnrekerle commented 1 year ago

Hi @lnrekerle , please see my review in the comments below.

@ielis I made all of the changes that you suggested, I personally think the test file is fine for now but I do plan to rewrite parts eventually. Let me know if anything else looks odd or if we can commit the PR. Thanks!