monarch-initiative / genophenocorr

Genotype Phenotype Correlation
https://monarch-initiative.github.io/genophenocorr/stable
MIT License
4 stars 1 forks source link

Show progress when loading phenopackets #72

Closed pnrobinson closed 7 months ago

pnrobinson commented 9 months ago
  1. add tqdm to for loop to show progress
  2. make sure we only query VEP once per distinct variant
ielis commented 8 months ago

Background

The load_phenopacket_folder takes a substantial amount of time and we need to keep the user aware of the progress. We can add tqdm library and

  1. make sure we only query VEP once per distinct variant

I don't think we have to worry a lot about querying VEP once per variant, since we cache the results locally after the first query. It would be nice to query only once, but I think it is not mission critical and, thus, has low priority.

Definition of done