Review `CohortAnalysis._remove_low_hpo_terms`

monarch-initiative / genophenocorr

Genotype Phenotype Correlation

https://monarch-initiative.github.io/genophenocorr/stable

MIT License

4 stars 1 forks source link

Review `CohortAnalysis._remove_low_hpo_terms` #92

Closed ielis closed 7 months ago

ielis commented 8 months ago

The function for removing infrequent HPO terms does not take into account the annotation propagation. Should we consider annotation propagation when deciding about term frequency?

pnrobinson commented 8 months ago

I think we should

ielis commented 8 months ago

OK, thanks! We'll work it into the analysis!