monarch-initiative / gpsea

A Python library for discovery of genotype-phenotype associations
https://monarch-initiative.github.io/gpsea/stable
MIT License
4 stars 1 forks source link

Allow to filter on annotation frequency #299

Closed pnrobinson closed 3 weeks ago

pnrobinson commented 3 weeks ago

… change to HpoMtcFilter method

@ielis I would like to add the overall frequency of annotation. e.g., if we have a cohort of size 100, and only 15 patients have information (observed excluded), this can still pass the frequency filter, but it is unlikely to be a good term to test for reasons of statistical power and medical interest (not an important finding and so it is rarely reported). I think we need to pass the total number of patients to the filter method or the constructor, but this would require an API change. Can we discuss the best way of doing this? This was the last thing we discussed with Mike, then we can finalize.