monarch-initiative / hpoannotqc

HPO Annotation QC
http://hpo-annotation-qc.readthedocs.io/en/latest/#
MIT License
11 stars 2 forks source link

Onset ids can be alt_ids #10

Closed pnrobinson closed 6 years ago

pnrobinson commented 6 years ago

Make sure all of the onset set ids are also primary ids. We can use a function something like this in the conversion of the small files

  private boolean checkIsNotAltId(TermId tid) {
        if (! ontology.getTermMap().containsKey(tid)) {
            errors.add("TermId not found at all in ontology: " + tid.getIdWithPrefix());
            return false;
        }
        TermId upToDate = ontology.getPrimaryTermId(tid);
        return tid.equals(upToDate);
    }

This should also be part of the Q/C check for the new V2 small files.

pnrobinson commented 6 years ago

fixed