search

monarch-initiative / koza

Data transformation framework for LinkML data models
https://koza.monarchinitiative.org/
BSD 3-Clause "New" or "Revised" License
48 stars 4 forks source link

KozaApp.schema is never initialized #155

Open ptgolden opened 4 weeks ago

ptgolden commented 4 weeks ago

I'm familiarizing myself with the codebase and cleaning up some type annotations, and I've noticed something off with the write method in the KozaApp class. Whether or not the class validates depends on the presence of the schema attribute in the class instance:

https://github.com/monarch-initiative/koza/blob/fceafe5755e222dba14cecf8b7df09ca7dd16831/src/koza/app.py#L151-L154

However, the code that sets that attribute is commented out in the __init__ method:

https://github.com/monarch-initiative/koza/blob/fceafe5755e222dba14cecf8b7df09ca7dd16831/src/koza/app.py#L52-L57

It looks like it was removed in a0ba9cb0. Is it intentional that that block of code in write() should never run?