search

monarch-initiative / mckb

Monarch Cancer Knowledge Base
1 stars 1 forks source link

Fix modelling of variants #10

Closed kshefchek closed 8 years ago

kshefchek commented 9 years ago

This is how we currently model variants: https://github.com/monarch-initiative/mckb/blob/master/tests/test_genotype.py#L219

We have 1-3 IDs in various combinations:

  1. CGD internal ID (exposed via a truncated MD5 of a unique string)
  2. dbSNP ID (sometimes)
  3. Cosmic ID (sometimes)

In the cases where we have 2 or all 3, should these be modelled as equivalent nodes, or do we need to relate them as cross references? cc @nlwashington

kshefchek commented 8 years ago

Fixed with 422013bc16bb4b4501e0dfbc49e2023585e90440