search

monarch-initiative / medgen

MedGen ingest.
1 stars 0 forks source link

MEDGENCUI possible future edge case handling #20

Closed joeflack4 closed 7 months ago

joeflack4 commented 7 months ago

Regarding contingent MEDGENCUI preservation

Options discussed: a. Test that fails if any MEDGENCUI appears b. Let them slip in with the rest of the UMLS / MEDGEN. c. Filter them out. Write them to a separate file. Or log to a file. d. A GH action that reviews the release and detects if MEDGENCUI and throw warning.

Edit: This only applies to the Mondo robot template, not for the HPO mappings work: #18.

joeflack4 commented 7 months ago

@twhetzel We discussed this at meeting today. But I also saw another comment from Nico in another PR. It looks like both you and Nico concur in the importance of handling this.

I'm going to go with option (c). And it will not take me long. So I will do it now

Edit: Actually went with an alternative to (c). Added a parameter with default to True to filter them out, and just filtered them out.

joeflack4 commented 7 months ago

Addressed by #19