monarch-initiative / monarch-app

Monarch Initiative website and API
https://monarchinitiative.org/
BSD 3-Clause "New" or "Revised" License
18 stars 6 forks source link

Ortholog Phenotypes checkbox is only available on a gene that has it's own phenotypes #626

Open kevinschaper opened 8 months ago

kevinschaper commented 8 months ago

I thought I'd come up with a great solution to allowing Ortholog Phenotypes, showing a checkbox to include ortholog phenotypes as well.

Screenshot 2024-03-05 at 1 39 40 PM

Unfortunately, there's no way to get to the checkbox if the gene itself doesn't have g2p associations, so we may need to go down the "fake category" route after all.

kevinschaper commented 8 months ago

This is actually a much bigger problem for Orthlog Disease, since there's no Disease option in the associations section for non-human animal genes, which means there's not actually a path to the checkbox.

One solution might be to move the checkbox up above, and have the association-counts re-generated with orthology traversing included, or have that model include both with and without traversing orthology?

Another solution would be the "fake category" route, where association counts offers counts on something like biolink:GeneToOrthologToPhenotypicFeature or maybe monarch:GeneToOrthologToPhenotypicFeature ... but I'm still hesitant to implement this feature using anything that looks like a real association category but isn't.