monarch-initiative / monarch-app

Monarch Initiative website and API
https://monarchinitiative.org/
BSD 3-Clause "New" or "Revised" License
16 stars 4 forks source link

Select associations to view on node page by association category rather than counterpart category #732

Closed kevinschaper closed 3 months ago

kevinschaper commented 3 months ago

Related to a discussion of phenotypes associated with GO terms, I looked for gene to phenotype associations where the subject closure contains GO:0016791 (phosphatase activity). I looked in the association table directly searching the subject_closure field, then confirmed, yup, I can get it via the API as well...then started looking deeper to understand what I would need to do for it to show up in the UI, only to realize that the way that we collapse associations down to a label for "the other side" of an association means that different kinds of associations can just overwrite each other in the dictionary where the label becomes a key (and eventually an Option choice in the UI)... so the GO annotations here are literally overwriting the option to see the gene to phenotype associations from this page

screenshot_2024-05-31_at_3 53 20___pm_720

but if I edit the configuration yaml to make the labels be for the association rather than just the class on the other side, there they are!

screenshot_2024-05-31_at_3 56 48___pm_720

It will take a slight tweak to the UI, but this should be a very easy fix

kevinschaper commented 3 months ago
Screenshot 2024-06-05 at 10 12 20 AM Screenshot 2024-06-05 at 10 15 52 AM

lookin good on dev!