monarch-initiative / monarch-app

Monarch Initiative website and API
https://monarchinitiative.org/
BSD 3-Clause "New" or "Revised" License
16 stars 3 forks source link

URI making slash instead of colon #743

Open glass-ships opened 1 week ago

glass-ships commented 1 week ago

https://dev.monarchinitiative.org/MGI:3696575

glass-ships commented 1 week ago

Tagging @amc-corey-cox for reference

glass-ships commented 1 week ago

Turns out I'm not immediately sure how to resolve this. It looks like we use prefixmaps to expand the URI

### make a singleton class that uses prefixmap and curies to expand curies

from prefixmaps import load_converter

__all__ = [
    "converter",
]

# this is a magic keyword that represents the "merged" context from Chris M's algorithm
# (https://github.com/linkml/prefixmaps/blob/main/src/prefixmaps/data/merged.csv)
converter = load_converter("merged")
glass-ships commented 1 week ago

I think I'll need to open a ticket with prefixmaps for this one. @monicacecilia are there other examples of invalid URI expansions that you know of? or just MGI

monicacecilia commented 6 days ago

@monicacecilia are there other examples of invalid URI expansions that you know of? or just MGI

@glass-ships I've only been looking at models, so I have only come across broken links from MGI. I don't see a new ticket for prefixmappings -- did you create one?

glass-ships commented 6 days ago

I did - https://github.com/linkml/prefixmaps/issues/72