Fix rendering association frequencies; use proper field for sorting them

monarch-initiative / monarch-app

Monarch Initiative website and API

https://monarchinitiative.org/

BSD 3-Clause "New" or "Revised" License

18 stars 6 forks source link

Fix rendering association frequencies; use proper field for sorting them #911

Open ptgolden opened 3 days ago

ptgolden commented 3 days ago

Related issues

Closes #910

Summary

Fixes rendering of frequency values in Disease-Phenotype association tables
Makes API calls to sort by computed frequency rather than just frequency_qualifier

Checks

[ ] All tests have passed (or issues created for failing tests)

netlify[bot] commented 3 days ago

Deploy Preview for monarch-app ready!

Name	Link
Latest commit	1182e26b6e7481da4bd3f06a9bd61b328267238f
Latest deploy log	https://app.netlify.com/sites/monarch-app/deploys/6740e8737eb1130008fca835
Deploy Preview	https://deploy-preview-911--monarch-app.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ptgolden commented 3 days ago

This will have one failing test when running TypeScript checks, since frequency_computed_sortable_float is not part of the Association LinkML model-- not sure whether to add it or to use a different model.

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.14%. Comparing base (af5ab7b) to head (1182e26).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #911 +/- ## ======================================= Coverage 71.14% 71.14% ======================================= Files 91 91 Lines 3136 3136 ======================================= Hits 2231 2231 Misses 905 905 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles