search

monarch-initiative / monarch-disease-ontology-RETIRED

THIS IS THE OLD REPO: Use this one instead: https://github.com/monarch-initiative/mondo-build
https://github.com/monarch-initiative/mondo-build
17 stars 9 forks source link

Nesting of syndromes "in other animals" under human equivalent #152

Closed jmcmurry closed 6 years ago

jmcmurry commented 8 years ago

Having animal diseases nested under human disease equivalent doesn't strike me as correct, but it may well be overly complex to model it with a species agnostic parent node. Thoughts?

screen shot 2016-09-02 at 2 24 27 pm screen shot 2016-09-02 at 2 24 07 pm
pnrobinson commented 8 years ago

Would it be possible to have a node saying something like "aninmal models of X" and then show the corresponding model underneath? I agree it is odd to just mix them into a larger list.

cmungall commented 8 years ago

Agreed, Model-of X is better.

We'd want to tweak the hierarchy display to show this too (but this needs so many tweaks anyway!)

cmungall commented 8 years ago

Although 'model-of' isn't quite right for veterinary animals - their diseases may serve as models, but they may just have the disease. So a different relation like analogy or homology or shares-features-of may be better.

jmcmurry commented 8 years ago

Although 'model-of' isn't quite right for veterinary animals

Precisely. Not sure how to fix it though. If you display human and animal equivalents as siblings, they are still children of a human-specific parent. Moreover, while the syndromic phenotypes may well be shared between humans and animals, the animal disease nosology may be quite different.

cmungall commented 8 years ago

I think the modeling issue is separate from the display issue.

Also we wouldn't be starting out with much in the way of an animal nosology. The subclass hierarchy of OMIA is flat, the structure is in the links to human diseases