monarch-initiative / monarch-disease-ontology-RETIRED

THIS IS THE OLD REPO: Use this one instead: https://github.com/monarch-initiative/mondo-build
https://github.com/monarch-initiative/mondo-build
17 stars 9 forks source link

potential Legacy_Concept_Name issues from NCIT (Fanconi Anemia vs Syndrome) #410

Closed cmungall closed 6 years ago

cmungall commented 6 years ago

What does Legacy_Concept_Name mean here:

https://ncit.nci.nih.gov/ncitbrowser/ConceptReport.jsp?dictionary=NCI%20Thesaurus&code=C4377 http://purl.obolibrary.org/obo/NCIT_C4377

potentially confusing as FA != FS. Even though this is marked 'legacy' can still be problematic.

although not NCI's problem, this is problematic when others use this, or have used a very old copy of NCIT, e.g.

id: DOID:1062
name: Fanconi syndrome
namespace: disease_ontology
...
synonym: "adult Fanconi Anemia" EXACT [NCI2004_11_17:C4377]

thankfully this has not caused us any issues, we place a low prior on some synonyms. But we should pre-process and check all NCIT sourced synonyms to see if they are active synonyms