search

monarch-initiative / monarch-ingest

Data ingest application for Monarch Initiative knowledge graph using Koza
https://monarchinitiative.org
15 stars 2 forks source link

Upgrade koza, handle node only ingests nicely, plus formatting changes #167

Closed kevinschaper closed 2 years ago

kevinschaper commented 2 years ago

Apologies for the extra formatting changes - it looks like we missed 'make format' on a few PRs.

glass-ships commented 2 years ago

Nice this looks awesome! I see you upgraded both koza to 0.1.7 and biolink model pydantic to 0.1.4, how does it handle that predicate name switch?

If you want, I can pull from your most recent commit and try to help with updating the tests and stuff - that would actually be a huge help in getting me more familiar and working on #106

kevinschaper commented 2 years ago

It looks like I didn't actually upgrade biolink_model_pydantic to 0.1.4 (I was hoping not to yet, at least!)- I checked with poetry show and it looks like the lock file is still at 0.1.2, so maybe the change that's showing up in the diff is just reflecting that the dev requirements for koza are now >= 0.1.4?

glass-ships commented 2 years ago

Ah that makes sense, ok. Thanks!