monarch-initiative / monarch-ingest

Data ingest application for Monarch Initiative knowledge graph using Koza
https://monarchinitiative.org
15 stars 2 forks source link

Write data and package versions to data/output #561

Closed glass-ships closed 8 months ago

glass-ships commented 10 months ago

Closes #394

glass-ships commented 10 months ago

Currently, output/versions.yaml looks like:

kg-version: 2024-01-23

packages:
  biolink: 3.6.0
  koza: 0.5.3
  monarch-ingest: 0.8.0

data:
  phenio: v2024-01-12
  alliance: 6.0.0

@kevinschaper should we a) rename this to metadata.yaml b) bring this in as is c) wait to bring it in and keep looking for ways to get versions of additional data sources

glass-ships commented 10 months ago

@matentzn Just wanted to bring this to your attention as a WIP solution to the issue of including data/tooling versions in some metadata file that gets uploaded alongside the knowledge graph / related files

matentzn commented 10 months ago

@glass-ships thank you very much for tagging me! This is fantastic. I have talked a bit to @kevinschaper about this, and I will propose a much more comprehensive dump pf information - but not very soon (after the 14th of February). The concept will be the same, but the written file will look different (JSON instead of yaml, and more metadata fields). For now, the only thing I would suggest is renaming the Koza parameter to --write-metadata, and go ahead with your PR, with the understanding that the file will look a bit different in the end.

caufieldjh commented 10 months ago

@matentzn I'm curious about the choice of JSON vs YAML here (but generally in favor of anything allowing better version tracking)

matentzn commented 10 months ago

@matentzn I'm curious about the choice of JSON vs YAML here (but generally in favor of anything allowing better version tracking)

@caufieldjh lets discuss this in a bespoke issue - I will make sure to loop you in also because of the b2ai work during the brainstorming process.