search

monarch-initiative / monarch-ingest

Data ingest application for Monarch Initiative knowledge graph using Koza
https://monarchinitiative.org
14 stars 1 forks source link

Populate type for HGNC & Alliance gene nodes #599

Closed kevinschaper closed 3 weeks ago

kevinschaper commented 1 month ago

Adds a lookup table for HGNC to SO term ID to populate the biolink type field for human genes. Also enables the type field for Alliance genes, which was commented out previously. Plus tests.**

Additionally, there are some unrelated formatting changes that came in as well.

Fixes #649

Update to add: The alternate approach would be to create a mapping table from the type strings provided by HGNC directly which in retrospect does sound like it's a little more maintainable. I'm open to rolling this back and going that way instead.

amc-corey-cox commented 3 weeks ago

This could go in... but I think there may be an error in after_download.sh. Please correct me if I've misunderstood how that will work.